Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AudioEffectRecord circular reference #74985

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix AudioEffectRecord circular reference #74985

merged 1 commit into from
Jun 20, 2023

Conversation

Rubonnek
Copy link
Member

@Rubonnek Rubonnek commented Mar 16, 2023 •
edited
Loading

Currently AudioEffectRecord creates an AudioEffectRecordInstance, both of which reference each other which prevents both objects from being freed.

This patch makes AudioEffectRecordInstance hold a weak reference to AudioEffectRecord to prevent this circular reference.

This patch removes the reference from AudioEffectRecordInstance altogether.

Fixes #34495

@Rubonnek Rubonnek requested a review from a team as a code owner March 16, 2023 14:49
@Rubonnek Rubonnek mentioned this pull request Mar 16, 2023
Merged
@Rubonnek Rubonnek added this to the 4.1 milestone Mar 16, 2023
@Rubonnek Rubonnek force-pushed the fix-audio-effect-leak-master branch 2 times, most recently from cb7b5c0 to 2fa34ed Compare March 17, 2023 03:11
ellenhp
ellenhp reviewed Mar 17, 2023
View reviewed changes
servers/audio/effects/audio_effect_record.h Outdated
@@ -44,7 +44,7 @@ class AudioEffectRecord;
class AudioEffectRecordInstance : public AudioEffectInstance {
GDCLASS(AudioEffectRecordInstance, AudioEffectInstance);
friend class AudioEffectRecord;
Ref<AudioEffectRecord> base;
Ref<WeakRef> base;
Copy link
Contributor

@ellenhp ellenhp Mar 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to just use a WeakRef here instead of Ref<WeakRef>? Pointing directly to the effect. It would also simplify the process logic.

Copy link
Member Author

@Rubonnek Rubonnek Mar 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon a second look, it made sense to remove it altogether. Keeping a reference to the AudioEffectRecord even as a weak reference introduces a race condition that's hard to avoid -- that thread might attempt to destroy itself and call Thread.wait_to_finish() which it shouldn't. We need an different thread to make that call.

The main thread, which is the one AudioServer::finish() runs on I believe, suffices. When the effect is removed from the bus, and if there's no other thread holding a reference to it, the AudioEffecRecord's destructor will signal the thread that AudioEffectRecordInstance has running to finish.

@Rubonnek Rubonnek force-pushed the fix-audio-effect-leak-master branch 2 times, most recently from ff12915 to 9b59b09 Compare March 18, 2023 19:59
@Rubonnek Rubonnek marked this pull request as draft March 18, 2023 21:52
@Rubonnek Rubonnek force-pushed the fix-audio-effect-leak-master branch 2 times, most recently from ee421cb to 922a671 Compare March 18, 2023 23:41
@Rubonnek Rubonnek marked this pull request as ready for review March 18, 2023 23:42
@Rubonnek
Copy link
Member Author

I've tested these changes with the following:

extends Node

var disable_recording_instead : bool = true

func _ready():
	var effect : AudioEffectRecord = AudioEffectRecord.new()
	AudioServer.add_bus_effect(0, effect, 0)
	effect.set_recording_active(true) # also tested false
	# Quit test -- memory should clear properly as well through AudioServer::finish()
	#get_tree().call_deferred("quit")

var once : bool = false
func _input(event : InputEvent) -> void:
	if not once and event is InputEventKey:
		once = true
		var effect:  AudioEffectRecord = AudioServer.get_bus_effect(0,0)
		if disable_recording_instead:
			print("Disabling effect...")
			effect.set_recording_active(false) # thread should clear
		else:
			print("Removing effect...")
			AudioServer.remove_bus_effect(0,0) # thread should clear now

@YuriSizov YuriSizov requested a review from ellenhp March 21, 2023 13:51
@MJacred MJacred mentioned this pull request May 7, 2023
Open
@akien-mga
Copy link
Member

Needs a rebase, but looks good to me overall, if the functionality still works well without this coupling.

CC @ellenhp in case you'd find time to give this another look.

@Rubonnek Rubonnek force-pushed the fix-audio-effect-leak-master branch from 922a671 to d19c376 Compare June 19, 2023 22:13
@akien-mga akien-mga merged commit 2861253 into godotengine:master Jun 20, 2023
@akien-mga
Copy link
Member

Thanks!

@Rubonnek Rubonnek deleted the fix-audio-effect-leak-master branch June 20, 2023 08:20
TheSecondReal0 added a commit to TheSecondReal0/godot that referenced this pull request Jun 29, 2023
@TheSecondReal0
Add option to reverse FlowContainer fill direction (HFlow bottom-to-t…
c6d94f8 
…op, VFlow right-to-left)

mid developing

behavior implemented

cleaned up

removed code dealing with vertical

ran --doctool

Merge branch 'flow-top-to-bottom' of https://github.com/TheSecondReal0/godot into flow-top-to-bottom

added support for vertical flow containers

Squashed commit of the following:

commit c83f912bcb33d441b90afe36bad38880acbe5f15
Merge: 9e903e462c 1a9739f591
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 28 15:58:57 2023 +0200

    Merge pull request #78796 from KoBeWi/vengeful_spirit_of_Godot3_tries_to_destroy_the_new_engine

    Fix crash with failed compatibility tiles

commit 1a9739f591a2cc7ee4ca8d4b90b5e20c6abaf390
Author: kobewi <[email protected]>
Date:   Wed Jun 28 15:11:10 2023 +0200

    Fix crash with failed compatibility tiles

commit 9e903e462caf3c215d3c1f6e771fa02928402b5f
Merge: bc756cd4f6 cea00ebf58
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 28 14:33:48 2023 +0200

    Merge pull request #78784 from timothyqiu/editor-import-plugin-example

    Fix function signature in `EditorImportPlugin` example

commit bc756cd4f6ec9532a0a9cf5623f98e4aed1bb581
Merge: 9a09ee5d02 2357837c43
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 28 14:33:41 2023 +0200

    Merge pull request #78740 from CURR-E/lifetime_randomness

    Correct description of `ParticleProcessMaterial.lifetime_randomness`

commit 9a09ee5d0217c4d5e5668fccddfa477bf16af357
Merge: d95b516d31 60b9eb169e
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 28 12:51:59 2023 +0200

    Merge pull request #78787 from RedworkDE/net-non-tool-reload

    C#: Fix reloading of non-tool scripts

commit 60b9eb169e8bcfe69cadea4e6f0f676cda6e993d
Author: RedworkDE <[email protected]>
Date:   Wed Jun 28 11:46:43 2023 +0200

    C# Fix reloading of non-tool scripts

commit 2357837c43cd28f82eeb87ca2a46a8311b264ace
Author: Curry <[email protected]>
Date:   Tue Jun 27 21:15:57 2023 +1000

    Correct description of ParticleProcessMaterial.lifetime_randomness

commit cea00ebf58e6b8dfbc968e978bf130dbdc92f1eb
Author: Haoyu Qiu <[email protected]>
Date:   Wed Jun 28 15:27:38 2023 +0800

    Fix function signature in EditorImportPlugin example

commit d95b516d312a9f3930a96c0fdd51cf975345f16f
Merge: 16508ead86 af01aed643
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 28 00:31:06 2023 +0200

    Merge pull request #78767 from KoBeWi/space_or_space

    Fix missing translations in EventListenerLineEdit

commit af01aed643a811f39fd97548c16b0a44d9bf4332
Author: kobewi <[email protected]>
Date:   Tue Jun 27 22:05:33 2023 +0200

    Fix missing translations in EventListenerLineEdit

commit 16508ead86c13051a1a701a64a63325cd647db53
Merge: 5e2f03fc99 70ca659143
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 27 23:02:02 2023 +0200

    Merge pull request #78745 from RandomShaper/fix_node_pr

    Fix node processing order

commit 5e2f03fc99df0c5d1de59b8713953e8b5644688c
Merge: 3c352a5a7d 538c4b62b7
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 27 23:01:24 2023 +0200

    Merge pull request #78711 from groud/explain_rpc

    Explain a bit more RPCs options

commit 70ca65914345971dccb80e8b68846f38c2739769
Author: Pedro J. Estébanez <[email protected]>
Date:   Tue Jun 27 12:48:14 2023 +0200

    Fix node internal/non-internal processing order

    Bonus:
    Fix issues in group-processing related setters

commit 3c352a5a7d2f68b859f0731d172ecd5f4bd32de4
Merge: 1b3bf48526 fb1bcac271
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 27 15:45:41 2023 +0200

    Merge pull request #78728 from Rindbee/reset-vp_pending-on-failure-or-not

    Fix that `ViewportTexture` cannot be setup again after failed setup

commit 1b3bf485263c4e2ebc8bcdb1d71b58064f4dc5bc
Merge: 950f4c3b41 104da478a8
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 27 13:09:50 2023 +0200

    Merge pull request #78727 from rburing/really_velocity

    Fix CharacterBody3D `get_position_delta()` and `get_real_velocity()`

commit 538c4b62b74d4ef3a822958096f24f0c6bdc70cd
Author: Gilles Roudière <[email protected]>
Date:   Mon Jun 26 16:40:48 2023 +0200

    Explain a bit more RPCs options

commit 950f4c3b41acef0403618dd6169be90530dea5da
Merge: 1f9e540f14 8321e0355e
Author: Fabio Alessandrelli <[email protected]>
Date:   Tue Jun 27 06:58:34 2023 +0200

    Merge pull request #78716 from akien-mga/mbedtls-load-error-handling

    mbedtls: Improve X509 certificate load error handling

commit fb1bcac2716c44e6c4fed9a6b029881fe19d1d2e
Author: Rindbee <[email protected]>
Date:   Tue Jun 27 06:12:50 2023 +0800

    Fix that `ViewportTexture` cannot be setup again after failed setup

    `vp_pending` is a flag indicating to wait for `ViewportTexture::_setup_local_to_scene`
    to be called. Once this method is called, no matter whether the setup will fail or not,
    it needs to be reset to `false`.

commit 104da478a89359ef0dffc3183205e81f26cc45a8
Author: Ricardo Buring <[email protected]>
Date:   Mon Jun 26 22:48:41 2023 +0200

    Fix CharacterBody3D get_position_delta()

    Calculate the difference of global positions.
    This also fixes get_real_velocity().

commit 1f9e540f14edbf2d496a1421f8d37e5b483c4c53
Merge: 9d089fe6e5 7c37a32897
Author: Yuri Sizov <[email protected]>
Date:   Mon Jun 26 20:59:24 2023 +0200

    Merge pull request #78720 from clayjohn/GLES3-tex-init

    Use a filter with mipmaps when initializing textures with mipmaps in GL Compatibility renderer

commit 7c37a32897712649fdbeb7b1a37f0957b2fb9fa3
Author: clayjohn <[email protected]>
Date:   Mon Jun 26 10:45:24 2023 -0700

    Use a filter with mipmaps when initializing textures with mipmaps in GL Compatibility renderer

    This works around a driver bug in some older devices and should be harmless on any spec-compliant device

commit 9d089fe6e501e4818fed1b0688631c4d65d1ba35
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 19:40:50 2023 +0200

    i18n: Sync translations with Weblate

commit 2e7a2c39e1b0dbccfbfc8e7066ec959924f99134
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 19:38:40 2023 +0200

    Bump version to 4.1-rc

    Faster release cycles are proving to work fairly well, and we have a lot more
    confidence label the current state as RC as we've had in the past.

    Let's get to 4.1-stable quickly and reopen development!

commit 5b220fbc1aec88d5e5a68069bad5a29d3f57b5fc
Merge: 0878766974 08ef3044ee
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 19:30:22 2023 +0200

    Merge pull request #78717 from KoBeWi/TracToR

    Fix missing translation in SceneCreateDialog

commit 08787669746d37d4eb5dfda0f1f5222cc0b8788e
Merge: 2930fbeecd fc0e37bbe0
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 19:25:28 2023 +0200

    Merge pull request #78719 from RandomShaper/fix_fixup

    Fix change of precedence in fixup

commit fc0e37bbe0f5b1fed6cdcb8cb5d607d36b634d2c
Author: Pedro J. Estébanez <[email protected]>
Date:   Mon Jun 26 19:20:34 2023 +0200

    Fix change of precedence in fixup

commit 08ef3044ee17bd45226257ae6d26893716c5e846
Author: kobewi <[email protected]>
Date:   Mon Jun 26 19:19:36 2023 +0200

    Fix missing translation in SceneCreateDialog

commit 8321e0355e8cab2e5222ac94d724874d173e1dd4
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 19:17:09 2023 +0200

    mbedtls: Improve X509 certificate load error handling

    Positive numbers shouldn't be treated as a hard failure:

    > For CRTs in PEM encoding, the function parses permissively:
    > if at least one certificate can be parsed, the function
    > returns the number of certificates for which parsing failed
    > (hence \c 0 if all certificates were parsed successfully).
    > If no certificate could be parsed, the function returns
    > the first (negative) error encountered during parsing.

    Fixes #77994.

commit 2930fbeecd7eab4ccffd4aea82964f2b8fd25e84
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 14:50:04 2023 +0200

    Update AUTHORS and DONORS list

    New contributors added to AUTHORS:
    @ajreckof, @AThousandShips, @bitsawer, @hakro, @mihe, @nongvantinh

    Thanks to all contributors and donors for making Godot possible!

commit 6b91f5704213543000823ec4b9876906a4549a0c
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 17:55:08 2023 +0200

    Fixup compilation warning after #78713

commit 61937011c93e4baff879548932c4406406114ff5
Merge: 3aaa787094 a39b683b12
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 17:28:31 2023 +0200

    Merge pull request #78713 from RandomShaper/fix_default_group_cq

    Ensure default node groups' call queue are processed

commit a39b683b122ee5a49bcf8daa363784a45a409899
Author: Pedro J. Estébanez <[email protected]>
Date:   Mon Jun 26 16:56:10 2023 +0200

    Ensure default node groups' call queue are processed

commit 3aaa7870949853d3f42a1f8b67d16f8f2602931c
Merge: d08ba5f3dc 91004df875
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 14:57:12 2023 +0200

    Merge pull request #78709 from Faless/mp/4.x_fix_delta_again

    [MP] Fix delta variables index decoding.

commit d08ba5f3dca8fb01e60bd369b9d5a77138659b50
Merge: 1b1e2403f9 0458ac4b81
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 14:56:47 2023 +0200

    Merge pull request #78670 from KoBeWi/cache_with_full_power

    Improve script icon cache

commit 1b1e2403f9ee1f0c8152e414c124d42491473e8e
Merge: afc5fa14ad da4590b3f1
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 14:56:24 2023 +0200

    Merge pull request #78653 from dalexeev/unexpose-doc-cache

    Unexpose `DocCache` class

commit 0458ac4b8191f514766d3e894ae563002a58ecfa
Author: kobewi <[email protected]>
Date:   Sun Jun 25 15:03:59 2023 +0200

    Improve script icon cache

commit 91004df87515bea5f49dff483db630ea453b14f8
Author: Fabio Alessandrelli <[email protected]>
Date:   Mon Jun 26 12:33:30 2023 +0200

    [MP] Fix delta variables index decoding.

commit afc5fa14adce7676746662751e63eab2d2ad4420
Merge: 320711bc8b 40e2168ac6
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 10:13:53 2023 +0200

    Merge pull request #78700 from AThousandShips/mutex_doc

    Fix documentation for `Mutex.try_lock`

commit 320711bc8be26d7c6c15b1203d028202bfa6444a
Merge: 33726f97b5 8bd14e5ca3
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 10:13:29 2023 +0200

    Merge pull request #78677 from smix8/navserver_default_values_4.x

    Add missing default Callables for new NavigationServer geometry parse and bake functions

commit 33726f97b5cee3742801a9d4fec6006bb78c3163
Merge: 8f2f5987a5 8e31d986c3
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 10:13:06 2023 +0200

    Merge pull request #78676 from smix8/doc_globalscope_navserver3d_4.x

    Fix GlobalScope doc link for NavigationServer3D

commit 8f2f5987a5cb48f959a17e95b57acbb9f217ad11
Merge: 710d2e7edf 1e8ca95cdc
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 10:12:42 2023 +0200

    Merge pull request #78673 from Geometror/fix-graphnode-hotzones

    [GraphEdit] Fix port hotzones at zoom levels other than 100%

commit 710d2e7edf54c477a15c7bc3fb91ead394b51fd9
Merge: a93c671b7d 4ae5dcca45
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 10:12:19 2023 +0200

    Merge pull request #78665 from smix8/fix_navobjects_map_4.x

    Fix NavObjects map assignments

commit a93c671b7d59d9d9be76558a8cc53bd87a0f42d1
Merge: e0de078d65 3147d84647
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 10:11:56 2023 +0200

    Merge pull request #78660 from AThousandShips/doc_node_path

    Add example for `NodePath` to grandparent

commit e0de078d65ef6225dab8355a5140a0ada2822bf9
Merge: a791103069 31fab43b8b
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 10:11:32 2023 +0200

    Merge pull request #78654 from Sauermann/fix-scene-load-crash

    Fix scene load crash related to `_ready`

commit a791103069f0547c9f3ba0055292301e91b20cb6
Merge: d577a2109a a1f517b77d
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 26 10:11:04 2023 +0200

    Merge pull request #78626 from Sauermann/fix-centered-doc

    Fix documentation of `popup_centered_ratio`

commit d577a2109a442dc7555a571db262e8b0bb93e32c
Merge: 3710f06929 e9c9285213
Author: Fabio Alessandrelli <[email protected]>
Date:   Mon Jun 26 10:06:00 2023 +0200

    Merge pull request #78662 from AThousandShips/mp_doc

    Clarify restrictions on nested `MultiplayerAPI` in `SceneTree`

commit 40e2168ac67a7fcd8cbab50de51ecf45d7ca570d
Author: Ninni Pipping <[email protected]>
Date:   Mon Jun 26 08:48:47 2023 +0200

    Fix documentation for `Mutex.try_lock`

    Documentation was not updated when return type was changed from `Error`
    to `bool`

commit 31fab43b8bde2d6b01f034c8c976756d5211abff
Author: Markus Sauermann <[email protected]>
Date:   Sat Jun 24 22:15:50 2023 +0200

    Fix scene load crash related to `_ready`

    The iterator might get invalidated during `_ready`-user-code.
    Prevent this by disallowing set_name during iterator-operations.

commit 8bd14e5ca333f2d34fcf6e148eb02e2978149e69
Author: smix8 <[email protected]>
Date:   Sun Jun 25 19:08:50 2023 +0200

    Add missing default Callables for new NavigationServer geometry parse and bake functions

    Adds missing default Callables for new NavigationServer geometry parse and bake functions.

commit 8e31d986c3ffa2f31bb05fab05767b5e930e516b
Author: smix8 <[email protected]>
Date:   Sun Jun 25 19:04:56 2023 +0200

    Fix GlobalScope doc link for NavigationServer3D

    Fixes GlobalScope doc link for NavigationServer3D.

commit 1e8ca95cdc01a3ef11a58e0434d76455cae85b96
Author: Hendrik Brucker <[email protected]>
Date:   Sun Jun 25 17:13:53 2023 +0200

    [GraphEdit] Fix port hotzones at zoom levels other than 100%

commit 4ae5dcca4563743d6c09c67e262c516020174fc4
Author: smix8 <[email protected]>
Date:   Sun Jun 25 05:28:21 2023 +0200

    Fix NavObjects map assignments

    Fixes NavObject map assignments.

commit e9c9285213725aa8fb2fa9b256d4fa775a66e297
Author: Ninni Pipping <[email protected]>
Date:   Sun Jun 25 11:29:05 2023 +0200

    Clarify restrictions on nested `MultiplayerAPI` in `SceneTree`

commit 3147d846471df67667cd331478943f5f0fda33b1
Author: Ninni Pipping <[email protected]>
Date:   Sun Jun 25 10:25:22 2023 +0200

    Add example for `NodePath` to grandparent

commit 3710f069293f2fde8afe33fea898c4b36fa5e943
Merge: 030c1a950e 39dfa8436e
Author: Rémi Verschelde <[email protected]>
Date:   Sat Jun 24 22:26:13 2023 +0200

    Merge pull request #78637 from V-Sekai/varying-offset-mismatch

    Varying mismatch causing shaders to fail.

commit da4590b3f10b715d5710c96b2741e8901400d34b
Author: Danil Alexeev <[email protected]>
Date:   Sat Jun 24 22:24:54 2023 +0300

    Unexpose `DocCache` class

commit 030c1a950e8cee19e72104b4fb79caba17a2d678
Merge: 24e7502279 1ee2697682
Author: Rémi Verschelde <[email protected]>
Date:   Sat Jun 24 11:58:01 2023 +0200

    Merge pull request #78643 from godotengine/revert-76711-fix-paste-value-not-updating-element-in-dictionaries/array

    Revert "Fix paste value not updated in dictionaries/arrays"

commit 1ee26976820c000743abaf2ad572af718062b8ee
Author: Rémi Verschelde <[email protected]>
Date:   Sat Jun 24 10:59:35 2023 +0200

    Revert "Fix paste value not updated in dictionaries/arrays"

commit 24e75022792c8389e5f2f0f3ca85bd6036054337
Merge: 19e7490c9a 0b19ec3498
Author: Rémi Verschelde <[email protected]>
Date:   Sat Jun 24 10:58:29 2023 +0200

    Merge pull request #78629 from Calinou/editor-export-mobile-web-csharp-error

    Display a message about missing C# support on Android/iOS/Web platforms

commit 39dfa8436eacfc7c916b87e64b3e8a9a03962559
Author: K. S. Ernest (iFire) Lee <[email protected]>
Date:   Fri Jun 23 21:36:38 2023 -0700

    Varying mismatch causing shaders to fail.

commit 0b19ec3498324e5fe71c8108f1e6b948b660ecdb
Author: Hugo Locurcio <[email protected]>
Date:   Sat Jun 24 00:01:53 2023 +0200

    Display a message about missing C# support on Android/iOS/Web platforms

    When trying to export a C# project, this displays an error message after
    creating a export preset for an unsupported platform.

    Support for these platforms is planned for a future release.

commit 19e7490c9ad399f1951fc6b5863b45a3fa477d3e
Merge: afe65de110 cc89321c9c
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 22:49:23 2023 +0200

    Merge pull request #78620 from clayjohn/GL-viewport

    Reset filter/repeat state of textures in GL Compatibility renderer when render target is cleared

commit afe65de11001b392cb9666b1ee32ea6c4ecf10ff
Merge: 68193bee9a f745299c36
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 22:45:51 2023 +0200

    Merge pull request #78591 from ajreckof/Fix-crash-when-removing-child-during-focus-exit-

    Fix crash when removing child during focus exit.

commit a1f517b77d7182a660ade11d5b18450e98f957bb
Author: Markus Sauermann <[email protected]>
Date:   Fri Jun 23 22:35:25 2023 +0200

    Fix documentation of `popup_centered_ratio`

commit f745299c36cfa0ae936e9d2ae829e8cca91956f0
Author: ajreckof <[email protected]>
Date:   Fri Jun 23 01:47:05 2023 +0200

    Fix crash when removing child during focus exit.

commit cc89321c9cb9b8d909c20afdec0b9e03b3ed2819
Author: clayjohn <[email protected]>
Date:   Fri Jun 23 10:57:56 2023 -0700

    Reset filter/repeat state of textures in GL Compatibility renderer when render target is cleared

commit 68193bee9a1f77427a13b92508d611b1e2110217
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 18:03:48 2023 +0200

    Revert "Fix that the focus-out notification got sent deferred"

    This reverts commit 8cdab04d7fd57aaabd790349cd8a4e9ec21a7edd.

    Fixes #78589.

commit f44b2d7898402a2a337bdc6a321f093a762dc18d
Merge: 46b2619223 f623509086
Author: Yuri Sizov <[email protected]>
Date:   Fri Jun 23 17:52:35 2023 +0200

    Merge pull request #78611 from YuriSizov/editor-cure-for-early-onset-layout-dementia

    Handle contextual editors gracefully when restoring layout

commit 46b2619223d5928381b1792e9736fd7e89b3bb53
Merge: 731df52084 7afb9dd275
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 17:23:56 2023 +0200

    Merge pull request #78614 from RandomShaper/disable_doc_cache

    Disable doc cache temporarily for pre-RC stabilization

commit 731df52084bc909cef9b4dcab6eaaf10c2282922
Merge: 9ab388c146 263c909349
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 17:23:29 2023 +0200

    Merge pull request #77532 from dsnopek/text_server_adv_gdextension

    Fix text_server_adv compiling as a GDExtension

commit 7afb9dd27591345b80565e8a694e452f8a82c339
Author: Pedro J. Estébanez <[email protected]>
Date:   Fri Jun 23 16:38:00 2023 +0200

    Disable doc cache temporarily for pre-RC stabilization

commit f6235090861f60aca5b407aa50a09d43a3c6eff9
Author: Yuri Sizov <[email protected]>
Date:   Fri Jun 23 15:46:06 2023 +0200

    Handle contextual editors gracefully when restoring layout

commit 8cfbc6bda295379f7c28a41f52cf89cb0d999a56
Author: Yuri Sizov <[email protected]>
Date:   Fri Jun 23 15:23:36 2023 +0200

    Revert "Remember only permanent bottom tabs"

    This reverts commit 5dde57e95827806101cede5d46391f2bd4b9150c.

commit 9ab388c146895cfacf87d09d28c148e186f348b6
Merge: 75f5e003de 44bec97d5e
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 12:36:44 2023 +0200

    Merge pull request #78609 from KoBeWi/—GodotEngine

    Unify window title format

commit 44bec97d5ea354458c1a48f3d7a03263b05fa8c1
Author: kobewi <[email protected]>
Date:   Fri Jun 23 12:21:56 2023 +0200

    Unify window title format

commit 75f5e003de35f784f7527333e5903c9c3b55ec63
Merge: fa7f8e34f2 5dde57e958
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 11:59:45 2023 +0200

    Merge pull request #78586 from KoBeWi/shader_editor_the_guardian_of_stability

    Remember only permanent bottom tabs

commit fa7f8e34f221c16719390865f538561350febef6
Merge: fd31dc7f32 e6e27f8be4
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 11:59:16 2023 +0200

    Merge pull request #78135 from BastiaanOlij/fix_openxr_passthrough

    Fix OpenXR Passthrough mode

commit 5dde57e95827806101cede5d46391f2bd4b9150c
Author: kobewi <[email protected]>
Date:   Thu Jun 22 23:14:14 2023 +0200

    Remember only permanent bottom tabs

commit fd31dc7f32855f23f0c38792fe42d501165f708c
Merge: 2d19cec174 982ca52e4c
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 10:43:10 2023 +0200

    Merge pull request #78601 from AThousandShips/doc_callable_fix

    Fix `MultiplayerSpawner` documentation

commit 982ca52e4cb8dd4b7b6aab9070999a3cfbcbd209
Author: Ninni Pipping <[email protected]>
Date:   Fri Jun 23 10:26:33 2023 +0200

    Fix `MultiplayerSpawner` documentation

commit 2d19cec17417f21408b16e0a9fe420ab500c32fc
Merge: fee49f4f9d 6f6999221d
Author: Fabio Alessandrelli <[email protected]>
Date:   Fri Jun 23 10:13:11 2023 +0200

    Merge pull request #78409 from AThousandShips/spawn_func_fix

    Do not serialize `MultiplayerSpawner.spawn_function`

commit fee49f4f9d9603a041cc30e85e33712a72fb8fc4
Merge: 8d65fb9ec7 ea96f5259f
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 08:49:06 2023 +0200

    Merge pull request #78596 from smix8/navmes_old_poly_clear_4.x

    Fix NavigationMesh not clearing old polygons

commit 8d65fb9ec7ac0d21c196d966c3b94c91ca895727
Merge: dbcbba5575 55fc56bfd4
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 08:48:43 2023 +0200

    Merge pull request #78584 from bgie/bgie

    Moved variables closer to usage to fix unused variable warning

commit dbcbba5575b4fdec309f684b4c2ef069076c1c73
Merge: f24f615b04 d9cc22af8f
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 08:48:20 2023 +0200

    Merge pull request #78575 from brno32/bind-light-param-intensity

    Binding LIGHT_PARAM_INTENSITY in RenderingServer

commit f24f615b0458b6549d2d4488e4d1be2e495856ff
Merge: 1d41ce76ca 237e3c6099
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 08:47:56 2023 +0200

    Merge pull request #78556 from QbieShay/qbe/hotzonehotfix

    Fix regression in visual nodes hotzones

commit 1d41ce76ca605b4f307043f2dee8f5baa85e5c8a
Merge: f9fc77bbe4 2bc85f9ac6
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 08:47:32 2023 +0200

    Merge pull request #78550 from BastiaanOlij/fix_openxr_depth_buffer

    Fix incorrect depth buffer option in OpenXR

commit ea96f5259fe924e1f29e77f81111220f30d7bc1f
Author: smix8 <[email protected]>
Date:   Fri Jun 23 01:09:15 2023 +0200

    Fix NavigationMesh not clearing old polygons

    Fixes NavigationMesh not clearing old polygons.

commit f9fc77bbe474e33967dfde69a2efa442f465fae2
Merge: c1ad74d4c3 4017524363
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 00:10:00 2023 +0200

    Merge pull request #77545 from aaronfranke/gltf-no-skeleton

    Fix exporting MeshInstances without a Skeleton in the GLTF module

commit c1ad74d4c3531310a6b72cbdf772f7b2a52674f7
Merge: b0c3c00d25 7c4921e794
Author: Rémi Verschelde <[email protected]>
Date:   Fri Jun 23 00:06:09 2023 +0200

    Merge pull request #78579 from aaronfranke/col-poly-obj-name

    Internally rename `parent` to `collision_object` in CollisionPolygon(2D/3D)

commit d9cc22af8fab650950da02552ce38057f859a549
Author: Alex Drozd <[email protected]>
Date:   Thu Jun 22 18:26:00 2023 +0200

    Binding LIGHT_PARAM_INTENSITY in RenderingServer

commit b0c3c00d2523e76583d37c41ce3730aa86933456
Merge: cb73a6e9f9 60c261ba2d
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 23:24:45 2023 +0200

    Merge pull request #78582 from Sauermann/fix-mouse-focus-nullcheck

    Re-add `mouse_focus`-nullcheck

commit 55fc56bfd4161cbb03818e235220cb72e9373b34
Author: Brecht Kuppens <[email protected]>
Date:   Thu Jun 22 23:01:09 2023 +0200

    Moved variables closer to usage to fix unused variable warning

commit 60c261ba2d22c952cde16253184f522a80c56a5b
Author: Markus Sauermann <[email protected]>
Date:   Thu Jun 22 21:58:19 2023 +0200

    Re-add `mouse_focus`-nullcheck

commit 7c4921e794fd6392afd7cc2ad7479cbaf197ee39
Author: Aaron Franke <[email protected]>
Date:   Thu Jun 22 14:06:05 2023 -0500

    Internally rename parent to collision_object in CollisionPolygon(2D/3D)

commit cb73a6e9f9046229a16b6b298c9086f03548e186
Merge: 88ce76537e 8a5af8183a
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 21:02:38 2023 +0200

    Merge pull request #78490 from clayjohn/GLES3-particles-subemit

    Add warnings and fallbacks for particles sub emitters when using the GL Compatibility rendering backend

commit 88ce76537e771527561c592660b70872976078b7
Merge: 120aa3fca8 818fe886a3
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 20:59:52 2023 +0200

    Merge pull request #68380 from AThousandShips/atlas_mesh_fix

    Bounds fixes in `TextureAtlas` import

commit 120aa3fca8ea31e1f55f5c718c59f125ee3c93a7
Merge: d87bdef2a4 399bce02cf
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 20:44:36 2023 +0200

    Merge pull request #78574 from Sauermann/fix-toplevel-reset

    Fix 3D `top_level` resetting

commit d87bdef2a4f7c83c6a236f8916ebac35ae4fd176
Merge: 522a2ea3f4 ef00de99b4
Author: Yuri Sizov <[email protected]>
Date:   Thu Jun 22 19:40:44 2023 +0200

    Merge pull request #78563 from bitsawer/fix_skeleton_error_spam

    Fix error spam when a mesh with bone weights has an invalid skeleton

commit 818fe886a356855001e0c32e7235cdefcfc7192c
Author: Ninni Pipping <[email protected]>
Date:   Fri Feb 24 15:58:42 2023 +0100

    Bounds fixes in `TextureAtlas` import

commit 237e3c6099223e3040ba10259f555e8f44c660c5
Author: QbieShay <[email protected]>
Date:   Thu Jun 22 12:59:48 2023 +0200

    Fix regression in visual nodes hotzones

commit 399bce02cf80239ab5d987e4b754eaf5c5d2eaaf
Author: Markus Sauermann <[email protected]>
Date:   Thu Jun 22 18:55:19 2023 +0200

    Fix 3D top_level resetting

    There is no need to erase the top_level flag on EXIT_TREE.
    During ENTER_TREE, `top_level = true` is not necessary, because it is
    already set to true.

commit 522a2ea3f41fef616980b4d3287f470dd3af9109
Merge: af16013905 da84efc96d
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 18:42:16 2023 +0200

    Merge pull request #78562 from MewPurPur/document-shader-include

    Document ShaderInclude

commit af160139057f4bd018e33020a42e4012e69efa5c
Merge: 283580d0cc 8848c395b6
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 18:32:25 2023 +0200

    Merge pull request #78571 from MewPurPur/include-extension-info

    Document file extensions of GDScript, CSharpScript, and Shader

commit 8848c395b6c46e99284bd5c21d52bd3d562c8a13
Author: MewPurPur <[email protected]>
Date:   Thu Jun 22 18:56:08 2023 +0200

    Add information about file extension to GDScript, CSharpScript, and Shader

commit 283580d0ccd981bb8186498385540c6f615ffcf5
Merge: c7e4dc1df7 edba45ec8b
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 18:32:01 2023 +0200

    Merge pull request #78566 from kleonc/repeated-sprite-selection-fix

    Fix click-selecting Sprites with repeated texture

commit c7e4dc1df7b39b5a5ac0108a223fd307a7238f91
Merge: 18bc912bc0 bca1f91291
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 18:31:38 2023 +0200

    Merge pull request #78561 from groud/fix_crash_in_TileSetAltasSourceEditor

    Fixes crash in TileSetAtlasSourceEditor

commit 18bc912bc0595a2d4ab2b5d42f9a6993c3b9a814
Merge: de3d4e3cec 1247c9e64f
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 18:31:14 2023 +0200

    Merge pull request #78543 from 3dnikita/fix-svg-in-ot-tag-closing

    Fix SVG tag closing for OT font glyphs

commit de3d4e3cec4e45739fdc8fb7ceff84950aab5b15
Merge: 0c4188fe32 9159208ed1
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 18:30:51 2023 +0200

    Merge pull request #78517 from AThousandShips/callable_serialize

    Ensure `RID`, `Callable`, and `Signal` are stored as strings

commit 0c4188fe32c9858f5921d9497cd1943e14e9c24f
Merge: 100082b3ac 77491d0a62
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 18:30:27 2023 +0200

    Merge pull request #78362 from AThousandShips/doc_curve_fix

    Clarify the return value of `Curve2D.sample_baked_with_rotation`

commit 100082b3acdef950dded744bda7ff16cc30afaaa
Merge: d586096415 999f3e2c13
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 18:30:04 2023 +0200

    Merge pull request #74760 from lassade/unicode-err-uses-replacement-char

    Don't append non unicode scalar values on the string, instead use the unicode replacement char

commit d586096415cd23c7c0c9ad5ec2edf8159ccb0474
Merge: e74bf831c2 7275819a91
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 18:29:34 2023 +0200

    Merge pull request #72720 from pkdawson/fix-mouse-capture

    DisplayServerWindows: Fix mouse capture when button up message is missed

commit da84efc96d81e19deddb801eafc92a6295be5eba
Author: MewPurPur <[email protected]>
Date:   Thu Jun 22 16:06:20 2023 +0200

    Document ShaderInclude

commit 77491d0a62454f22ebb44142d4e570735cbc6ad7
Author: Ninni Pipping <[email protected]>
Date:   Sat Jun 17 11:01:05 2023 +0200

    Clarify the return value of `Curve2D.sample_baked_with_rotation`

    The return value is a broken `Transform2D`, this clarifies how to use
    it.

commit 9159208ed1c850437946d4f93c407bb5d51f4258
Author: Ninni Pipping <[email protected]>
Date:   Wed Jun 21 11:06:32 2023 +0200

    Ensure `RID`, `Callable`, and `Signal` are stored as strings

    Prevents parser errors in `.tscn` and `.tres` files where the assignment
    would otherwise be empty.

commit 1247c9e64fe658b64d28531f241f184d0e10c4d6
Author: 3dnikita <[email protected]>
Date:   Thu Jun 22 04:13:03 2023 +0300

    Fix SVG tag closing for OT font glyphs

    Prevent ThorVG "Failed to create SVG canvas" errors
    by self-closing empty SVG tags in OpenType fonts,
    so the glyphs are renderred correctly in Controls.

    Fixes #78374

commit edba45ec8b9ea0c94f7622476356c64d0af2bf0b
Author: kleonc <[email protected]>
Date:   Thu Jun 22 16:23:15 2023 +0200

    Fix click-selecting Sprites with repeated texture

commit bca1f91291afa988563e6f545104af566e9845e0
Author: Gilles Roudière <[email protected]>
Date:   Thu Jun 22 15:03:53 2023 +0200

    Fixes crash in TileSetAtlasSourceEditor

commit ef00de99b432a5d8b990673dd115c9d947a673e0
Author: bitsawer <[email protected]>
Date:   Thu Jun 22 15:37:54 2023 +0300

    Fix error spam when a mesh with bone weights has an invalid skeleton

commit e74bf831c2d3ece79b849405f03999281f807648
Merge: 57e61db115 84c8946565
Author: Yuri Sizov <[email protected]>
Date:   Thu Jun 22 12:51:03 2023 +0200

    Merge pull request #78549 from dalexeev/gds-fix-prop-list-name-check

    GDScript: Remove unnecessary name check in `_get_property_list()`

commit 57e61db115909c062e6c9864cbd7aa44f2f64471
Merge: b0299c9ad1 e0f644a48d
Author: Yuri Sizov <[email protected]>
Date:   Thu Jun 22 12:45:02 2023 +0200

    Merge pull request #75533 from RedworkDE/net-no-reload-noncollectible

    C#: Fix editor integration breaking and causing error spam when reloading assemblies fails

commit b0299c9ad1eb029cd7a89e095ffa3add92187d67
Merge: 95f561dc30 731a13a1ba
Author: Yuri Sizov <[email protected]>
Date:   Thu Jun 22 12:44:25 2023 +0200

    Merge pull request #76586 from rcorre/register-language-race

    Fix a race condition in ScriptServer

commit 84c894656522f0eb44ff971208ddded68dd1ea4b
Author: Danil Alexeev <[email protected]>
Date:   Thu Jun 22 11:32:09 2023 +0300

    GDScript: Remove unnecessary name check in `_get_property_list()`

commit 2bc85f9ac62e5739339c5dd4e301ef8cbf8bbd4c
Author: Bastiaan Olij <[email protected]>
Date:   Thu Jun 22 19:03:08 2023 +1000

    Fix incorrect depth buffer option in OpenXR

commit 95f561dc30b33d77198868f4f422b4f9e068b584
Merge: 3e09b0bfa7 0f64c6a952
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 10:30:11 2023 +0200

    Merge pull request #78541 from BWPanda/patch-1

    Fix example in JSON class.

commit 3e09b0bfa77029be82067fef15467bfb9e5fab6b
Merge: 9d9740fc35 df740f6865
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 10:30:07 2023 +0200

    Merge pull request #78508 from Wuqiqi123/free_depth_texture_when_frame_buffer_check_failed

    Free depth texture after check framebuffer complete failed

commit 9d9740fc35e91052546a0e9e580ca7b48a5ff2ba
Merge: d40c45ed99 e11e9d2b9a
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 10:30:04 2023 +0200

    Merge pull request #78486 from dinoplane/fix-sat-slider

    Use cached saturation for color picker when value is 0

commit d40c45ed993db199f1db08ef51991cd0cfdcf1f6
Merge: b6ba664830 2747dd35e7
Author: Rémi Verschelde <[email protected]>
Date:   Thu Jun 22 10:29:56 2023 +0200

    Merge pull request #77688 from L4Vo5/clarify-deferred

    Clear up misconceptions about when deferred things run in the docs

commit df740f686541c69fc44247ec4a303cc9eeca56c3
Author: Qiqi Wu <[email protected]>
Date:   Wed Jun 21 16:13:01 2023 +0800

    free color and depth texture after check framebuffer complete failed

commit 0f64c6a952da1e5323d0578ac24b1715549fef2e
Author: Peter Anderson <[email protected]>
Date:   Wed Jun 21 22:41:14 2023 +0000

    Fix example in JSON class.

commit e11e9d2b9a7b14f6deea6eb3490146bbac0d3773
Author: dinoplane <[email protected]>
Date:   Tue Jun 20 11:03:30 2023 -0700

    Use cached saturation for color picker when value is 0

commit b6ba664830d9ff1bd7eeb72294fa1e7a3827e42e
Merge: f2ce0b6741 5ec1b698d2
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 23:22:00 2023 +0200

    Merge pull request #78528 from jeanahelver/master

    Fix missing enum value for `Window.initial_position`

commit 5ec1b698d24173542ede9e8f31ff552875d508d5
Author: jeana helver <[email protected]>
Date:   Wed Jun 21 17:56:23 2023 +0200

    Fix missing enum value for `Window.initial_position`

    Reorder the properties in a possibly more intuitive order.

    Co-authored-by: Rémi Verschelde <[email protected]>

commit 8a5af8183a86ef20de7027fc43cab20fb13060cc
Author: clayjohn <[email protected]>
Date:   Tue Jun 20 14:03:14 2023 -0700

    Add warnings and fallbacks for particles sub emitters when using the GL Compatibility rendering backend

    Co-authored-by: Hugo Locurcio <[email protected]>

commit f2ce0b6741049b69efb455394b8a161f68a468a6
Merge: 1e44b47970 8ce8216d17
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 21:52:15 2023 +0200

    Merge pull request #78521 from jpcerrone/fix_static_vars_refs

    Fix errors destroying script with static variables

commit 1e44b479702a577037c49600ce50f4b8a61b102c
Merge: e68270cace 952b4b3f38
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 21:51:52 2023 +0200

    Merge pull request #78499 from BastiaanOlij/fix_stereo_decals

    Apply reprojection in multiview for our cluster lookup

commit e68270caced6130f2833120e06a9ac368e344421
Merge: faf3faa8c8 dbdbe5b042
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 21:51:29 2023 +0200

    Merge pull request #78488 from paulloz/dotnet-check-projectpath-not-solutionpath

    Fix condition blocking .NET project build

commit faf3faa8c85a4bad00bc944a90e7f75e7ba5d519
Merge: 81a0199be4 f3bf75fbb4
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 21:51:05 2023 +0200

    Merge pull request #77744 from dalexeev/gds-reset-block-locals-on-exit

    GDScript: Reset local variables on exit from block

commit 81a0199be46679213bd2a46cb75394c05eb52c30
Merge: 28a60b3de0 6c28b8edd3
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 21:50:33 2023 +0200

    Merge pull request #78533 from anvilfolk/sadrevert

    GDScript: fix regression when checking for virtual function implementation

commit 6c28b8edd3bd43c28c4c5671b4b1800e14b47949
Author: ocean (they/them) <[email protected]>
Date:   Wed Jun 21 15:13:45 2023 -0400

    GDScript: fix regression when checking for virtual function implementation.

    Unfortunately it appears the virtual function checks in #77324 are not
    trustworthy at runtime, because objects can have scripts attached, but
    this information is not always available at compile-time. These checks
    need to be removed.

    The rest of the PR is still useful, making all method flags available to
    the analyzer, so a full revert isn't necessary/desirable.

    This reopens #76938, which will need another solution.

commit dbdbe5b042501f950e5facec9f4b6512cc85997a
Author: Paul Joannon <[email protected]>
Date:   Tue Jun 20 21:32:38 2023 +0200

    Fix condition blocking .NET project build

    Since #73015, the build commands are called on project files instead of solution ones.

commit 8ce8216d174276a714e65dd4d407ce8d158ab21e
Author: jpcerrone <[email protected]>
Date:   Wed Jun 21 11:42:19 2023 -0300

    Fix errors destroying script with static variables
    Fixes #78376
    After #78138 'script_list' is now cleared in 'GDScriptLanguage::finish'
    Because of that, we can safely remove the removal from that list that
    happens on 'GDScript::~GDScript'.

commit 28a60b3de02e8cfcc742a248078e6b7ee8f728b1
Merge: a2ce7a8f88 9ddd3c2af6
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 16:17:07 2023 +0200

    Merge pull request #78518 from Bromeon/feature/gdextension-since

    Add GDExtension `@since` attribute

commit 731a13a1ba4d11e0c7daa7e32335c365f9f190cd
Author: Ryan Roden-Corrent <[email protected]>
Date:   Sat Apr 29 13:54:52 2023 -0400

    Fix race in ScriptServer.

    Fixes #76581.

    TSAN flagged this issue on starting the editor:

    1. main calls register_core_types, which calls IP::create(), which calls Thread::start on the resolver thread
    2. Thread::callback calls ScriptServer::thread_enter(), as "Scripts may need to attach a stack."
    3. ScriptServer::thread_enter() accesses ScriptServer::_languages, which is still being initialized on the main thread by initialize_gdscript_module

    This fixes the issue by skipping thread enter/exit notifications if languages have not finished initializing yet.
    I'm assuming that notifying un-initialized languages of thread starts/stops would have been pointless anyways. If we need to somehow notify languages of threads before the languages initialize, we'll need a different solution.

    ```
    Godot Engine v4.0.2.stable.custom_build.7a0977ce2 - https://godotengine.org
    ==================
    WARNING: ThreadSanitizer: data race (pid=9426)
      Write of size 4 at 0x55615b187cd0 by main thread:
        #0 ScriptServer::register_language(ScriptLanguage*) /home/rcorre/src/godot/godot/core/object/script_language.cpp:177:28 (godot.linuxbsd.editor.x86_64.llvm.san+0x9e52ab9) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #1 initialize_gdscript_module(ModuleInitializationLevel) /home/rcorre/src/godot/godot/modules/gdscript/register_types.cpp:118:3 (godot.linuxbsd.editor.x86_64.llvm.san+0x36f9c6f) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #2 initialize_modules(ModuleInitializationLevel) /home/rcorre/src/godot/godot/modules/register_module_types.gen.cpp:93:2 (godot.linuxbsd.editor.x86_64.llvm.san+0x2f50499) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #3 Main::setup2(unsigned long) /home/rcorre/src/godot/godot/main/main.cpp:1961:2 (godot.linuxbsd.editor.x86_64.llvm.san+0x2f1d40d) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #4 Main::setup(char const*, int, char**, bool) /home/rcorre/src/godot/godot/main/main.cpp:1879:10 (godot.linuxbsd.editor.x86_64.llvm.san+0x2f16370) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #5 main /home/rcorre/src/godot/godot/platform/linuxbsd/godot_linuxbsd.cpp:61:14 (godot.linuxbsd.editor.x86_64.llvm.san+0x2e67e1f) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)

      Previous read of size 4 at 0x55615b187cd0 by thread T1:
        #0 ScriptServer::thread_enter() /home/rcorre/src/godot/godot/core/object/script_language.cpp:244:22 (godot.linuxbsd.editor.x86_64.llvm.san+0x9e54aed) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #1 Thread::callback(unsigned long, Thread::Settings const&, void (*)(void*), void*) /home/rcorre/src/godot/godot/core/os/thread.cpp:61:2 (godot.linuxbsd.editor.x86_64.llvm.san+0x9464ab0) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #2 void std::__invoke_impl<void, void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>(std::__invoke_other, void (*&&)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long&&, Thread::Settings&&, void (*&&)(void*), void*&&) /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/invoke.h:61:14 (godot.linuxbsd.editor.x86_64.llvm.san+0x9465283) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #3 std::__invoke_result<void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>::type std::__invoke<void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>(void (*&&)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long&&, Thread::Settings&&, void (*&&)(void*), void*&&) /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/invoke.h:96:14 (godot.linuxbsd.editor.x86_64.llvm.san+0x9465283)
        #4 void std::thread::_Invoker<std::tuple<void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>>::_M_invoke<0ul, 1ul, 2ul, 3ul, 4ul>(std::_Index_tuple<0ul, 1ul, 2ul, 3ul, 4ul>) /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/std_thread.h:258:13 (godot.linuxbsd.editor.x86_64.llvm.san+0x9465283)
        #5 std::thread::_Invoker<std::tuple<void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>>::operator()() /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/std_thread.h:265:11 (godot.linuxbsd.editor.x86_64.llvm.san+0x9465283)
        #6 std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (*)(unsigned long, Thread::Settings const&, void (*)(void*), void*), unsigned long, Thread::Settings, void (*)(void*), void*>>>::_M_run() /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/12.2.1/../../../../include/c++/12.2.1/bits/std_thread.h:210:13 (godot.linuxbsd.editor.x86_64.llvm.san+0x9465283)
        #7 execute_native_thread_routine /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/thread.cc:82:18 (libstdc++.so.6+0xd72c2) (BuildId: 6fe66a2d539a78c993bd2d377e00fad389220963)

      Location is global 'ScriptServer::_language_count' of size 4 at 0x55615b187cd0 (godot.linuxbsd.editor.x86_64.llvm.san+0xbf46cd0)

      Thread T1 (tid=9431, running) created by main thread at:
        #0 pthread_create <null> (godot.linuxbsd.editor.x86_64.llvm.san+0x2de5776) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #1 __gthread_create /usr/src/debug/gcc/gcc-build/x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu/bits/gthr-default.h:663:35 (libstdc++.so.6+0xd73a9) (BuildId: 6fe66a2d539a78c993bd2d377e00fad389220963)
        #2 std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State>>, void (*)()) /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/thread.cc:147:37 (libstdc++.so.6+0xd73a9)
        #3 IP::IP() /home/rcorre/src/godot/godot/core/io/ip.cpp:347:19 (godot.linuxbsd.editor.x86_64.llvm.san+0x962cbcd) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #4 IPUnix::IPUnix() /home/rcorre/src/godot/godot/drivers/unix/ip_unix.cpp:261:9 (godot.linuxbsd.editor.x86_64.llvm.san+0x4aee599) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #5 IPUnix::_create_unix() /home/rcorre/src/godot/godot/drivers/unix/ip_unix.cpp:258:9 (godot.linuxbsd.editor.x86_64.llvm.san+0x4aee599)
        #6 IP::create() /home/rcorre/src/godot/godot/core/io/ip.cpp:339:9 (godot.linuxbsd.editor.x86_64.llvm.san+0x962ca5e) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #7 register_core_types() /home/rcorre/src/godot/godot/core/register_core_types.cpp:279:7 (godot.linuxbsd.editor.x86_64.llvm.san+0x93e2333) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #8 Main::setup(char const*, int, char**, bool) /home/rcorre/src/godot/godot/main/main.cpp:690:2 (godot.linuxbsd.editor.x86_64.llvm.san+0x2f08a49) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)
        #9 main /home/rcorre/src/godot/godot/platform/linuxbsd/godot_linuxbsd.cpp:61:14 (godot.linuxbsd.editor.x86_64.llvm.san+0x2e67e1f) (BuildId: 780a9db7c37d88e78d5ee659c4fa1cd378abd048)

    SUMMARY: ThreadSanitizer: data race /home/rcorre/src/godot/godot/core/object/script_language.cpp:177:28 in ScriptServer::register_language(ScriptLanguage*)
    ```

    Co-authored-by: Pedro J. Estébanez <[email protected]>

commit a2ce7a8f8817f516995c0e88cae4519a50ab9639
Merge: ee41b2097c bf04c55175
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 13:52:42 2023 +0200

    Merge pull request #78494 from kinami-imai/SSDinaTvuI8geW91IGFsbAo=

    Fix lambda parsing continuing on subsequent lines

commit bf04c5517534848970de1652866b13afac50eba9
Author: 今井きなみ <[email protected]>
Date:   Tue Jun 20 00:47:18 2023 +0200

    Fix lambda parsing continuing on subsequent lines #73273

commit e0f644a48da49843ad63a06982af85f13783899c
Author: RedworkDE <[email protected]>
Date:   Fri Mar 31 11:53:16 2023 +0200

    C#: Fix editor integration breaking and causing error spam when reloading assemblies fails

    - Do not reload scripts from non-collectible assemblies
    - Do not load GodotTools as collectible
    - Do not attempt to reload the same project assembly forever

commit 9ddd3c2af67f440092d5284992246f1b4bf2cf25
Author: Jan Haller <[email protected]>
Date:   Wed Jun 21 12:47:48 2023 +0200

    GDExtension `@since` attribute

    All GDExtension function pointer types are versioned using a `@since` attribute, denoting the Godot minor version in
    which they were introduced. This allows bindings to query if a feature is available for a target API version, or provide
    a polyfill/fallback for it. It also serves as documentation for humans giving a feeling about recency of features.

commit ee41b2097c7881bcd63bb7d5d5690fad8a9ade1d
Merge: 735bf14ae7 6e182d41f4
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 12:43:01 2023 +0200

    Merge pull request #78509 from MewPurPur/redraw-code-edit-on-mouse-exit

    Hide breakpoint indicator when mouse leaves CodeEdit

commit 735bf14ae7f6d6dbd7f66c3117f588fb69b0ff03
Merge: ebd44641c5 ab4e89ecde
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 12:42:54 2023 +0200

    Merge pull request #76636 from angel-721/test-http

    Add HTTPClient unit tests

commit ab4e89ecde3edb9018fee6d541b795ea5a82ea15
Author: angel-721 <[email protected]>
Date:   Sun Apr 30 18:02:23 2023 -0600

    Add HTTPClient unit tests

commit 6e182d41f4aed3d313435d410e52e2aadb0650db
Author: MewPurPur <[email protected]>
Date:   Wed Jun 21 11:22:46 2023 +0200

    Hide breakpoint indicator when mouse leaves CodeEdit

commit ebd44641c53ecfafb3fa0bd5f0f6abcbc3a25e05
Merge: 4fc045e9b5 c1c5b0a435
Author: Yuri Sizov <[email protected]>
Date:   Wed Jun 21 11:19:36 2023 +0200

    Merge pull request #78492 from KoBeWi/too_slow

    Update indices after removing custom data layers

commit 4fc045e9b53becf063b50a457709ade403235d80
Merge: ada712e06a ac36776729
Author: Yuri Sizov <[email protected]>
Date:   Wed Jun 21 11:19:24 2023 +0200

    Merge pull request #76152 from timothyqiu/tile-resize-clamp

    Fix tile resizing towards atlas boundary

commit ada712e06a471da2a2f4646237830bbd7980c114
Merge: 5285927f51 42faab826d
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 10:20:11 2023 +0200

    Merge pull request #78504 from timothyqiu/gridmap-selection

    Fix GridMap tile picking when a search filter is applied

commit 5285927f5185ed0478061abdeba75890930bd2ca
Merge: d252f43a86 0d0e8b0a8a
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 10:19:47 2023 +0200

    Merge pull request #78495 from lyuma/import_tracks_single_clip

    Fix Import Tracks import setting for single clip

commit d252f43a865abaa1074f273fe4e44a75efbcc796
Merge: 3e5c50bc2f e1bdde911c
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 10:19:24 2023 +0200

    Merge pull request #78449 from Scony/add-agent-n-map-navserver-tests

    Add `agent` and `map` tests for 'NavigationServer3D'

commit 3e5c50bc2f3eec3415861587ab292a11decf5bf1
Merge: 78518be194 9dc850a2ea
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 10:19:00 2023 +0200

    Merge pull request #78250 from Ryan-000/master

    Clarify that authority is not automatically replicated

commit 78518be1946da573232731489e19cc74ea5f4d10
Merge: 9e56f28d0e c39cae4dcf
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 10:18:37 2023 +0200

    Merge pull request #75444 from lpriebe/editor-run-arg-split-fix

    Prevent quoted args in `editor/main_run_args` from being split at spaces

commit 9e56f28d0e77530f21bd38d1ef5dfb9b31072818
Merge: 5025d95d41 19d77ea90d
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 10:18:09 2023 +0200

    Merge pull request #75345 from Rindbee/fix-wrong-description-in-EditorSettings

    Fix wrong descriptions in EditorSettings

commit 5025d95d41447cf1b85008095638a0a8dffab999
Merge: 38ae7b58d1 20ceba9e82
Author: Rémi Verschelde <[email protected]>
Date:   Wed Jun 21 10:17:37 2023 +0200

    Merge pull request #69027 from Uxeron/AudioListener2DRotationFix

    Fix AudioListener2D ignoring rotation for positional audio

commit 20ceba9e820695aed4491b732ac743f3b92f93bf
Author: Uxeron <[email protected]>
Date:   Tue Nov 22 22:37:38 2022 +0200

    Fix AudioListener2D ignoring rotation

commit 42faab826d5cfc9225d02bb5931fad9b1e336264
Author: Haoyu Qiu <[email protected]>
Date:   Wed Jun 21 12:02:07 2023 +0800

    Fix GridMap tile picking when a search filter is applied

commit 952b4b3f3829f9185e13de62bb4c8ac9c27db43a
Author: Bastiaan Olij <[email protected]>
Date:   Wed Jun 21 10:59:12 2023 +1000

    Apply reprojection in multiview for our cluster lookup

commit c1c5b0a4357a8f84fa29aa199b98af54d4b25537
Author: kobewi <[email protected]>
Date:   Wed Jun 21 00:01:59 2023 +0200

    Update indices after removing custom data layers

commit 38ae7b58d17b63def71a773c1da6cd17406f81a2
Merge: 329652b6fe 13e65da804
Author: Yuri Sizov <[email protected]>
Date:   Wed Jun 21 03:03:19 2023 +0200

    Merge pull request #78350 from ajreckof/you-know-when-you-want-to-search-this-member-you-don't-know-and-then-you-have-the-script-editor-all-over-the-place-now-it-should-not-happen-anymore-hopefully

    Fix placement and style of the "Make Floating" button

commit 19d77ea90d5214f3c54abff0bb5d447564892fbb
Author: Rindbee <[email protected]>
Date:   Sun Mar 26 13:11:24 2023 +0800

    Fix wrong descriptions in EditorSettings

    Fix wrong descriptions about `editors/3d/grid_division_level_max`
    and `editors/3d/grid_division_level_min`.

commit 13e65da804f0b94423c20af739e0b53dc3fe91f0
Author: ajreckof <[email protected]>
Date:   Wed Jun 21 01:00:37 2023 +0200

    Fix wrong placement of the Make Floating Button.

commit 0d0e8b0a8a9ae412a43916ba091ad79af94adeb8
Author: Lyuma <[email protected]>
Date:   Tue Jun 20 15:49:38 2023 -0700

    Fix Import Tracks import setting for single clip

commit 9dc850a2ea6b344e849580f6e45058176ffa98d9
Author: Ryan Memarpour <[email protected]>
Date:   Wed Jun 14 20:16:30 2023 -0400

    Clarify that authority is not automatically replicated.

commit 329652b6feac2114c4e30062f18ece36d4e3addc
Merge: 58fae90ff3 ceed30c442
Author: Yuri Sizov <[email protected]>
Date:   Tue Jun 20 21:19:20 2023 +0200

    Merge pull request #78392 from Gallilus/master

    Fix `Ref<>.is_valid()` for ScriptInstanceExtension

commit 58fae90ff39c30d19ecd902d3ae9a4de136ca501
Merge: e002fb232a c54d407fa5
Author: Yuri Sizov <[email protected]>
Date:   Tue Jun 20 20:49:16 2023 +0200

    Merge pull request #78477 from groud/fix_tileset_set_as_local_to_scene

    Fixes TileSet set as local to scene

commit e002fb232a36e652bd2bdebf1dda6837ed89f51c
Merge: ab545ece85 01f887ee4f
Author: Yuri Sizov <[email protected]>
Date:   Tue Jun 20 20:48:42 2023 +0200

    Merge pull request #77717 from L4Vo5/clarify-idle-enums

    Clarify when things with _IDLE and _PHYSICS enums will run

commit ab545ece85016ad16f0274ba6f40d1ea3d81d9a8
Merge: db08287b18 4067907074
Author: Yuri Sizov <[email protected]>
Date:   Tue Jun 20 20:39:52 2023 +0200

    Merge pull request #76398 from spanzeri/insert-key-crash

    Fix insert key crash with no animation

commit db08287b18cdba4377a42304f4b2b192b6e856e5
Merge: d7af287ce3 1a70d82606
Author: Yuri Sizov <[email protected]>
Date:   Tue Jun 20 20:38:02 2023 +0200

    Merge pull request #78456 from aaronfranke/tex-format-should

    Check if the required texture format is imported in the export dialog

commit ceed30c44279bd56665e72044ed25e8e86f6eb25
Author: David Cambré <[email protected]>
Date:   Sun Jun 18 11:07:04 2023 +0200

    Fix Ref<>.is_valid() for ScriptInstanceExtension

    Only check the reference not the value.

commit 01f887ee4f9bbe4516730e9382d9bfbfe53d3df4
Author: L4Vo5 <[email protected]>
Date:   Wed May 31 20:38:19 2023 -0300

    Clarify when things with _IDLE and _PHYSICS enums will run

commit 1a70d8260643b769587bf95f12d42d08d74d1b5b
Author: Aaron Franke <[email protected]>
Date:   Mon Jun 19 20:03:51 2023 -0500

    Check if the required texture format is imported in the export dialog

commit 263c909349cb64d988bba26eb62c01a3a0b19791
Author: David Snopek <[email protected]>
Date:   Fri May 26 16:40:53 2023 -0500

    Fix text_server_adv compiling as a GDExtension

commit c54d407fa55f49c399ee9eb03066612f90aa20f3
Author: Gilles Roudière <[email protected]>
Date:   Tue Jun 20 16:35:22 2023 +0200

    Fixes TileSet set as local to scene

commit e1bdde911c21c76e866f16e4208d517438e44d2e
Author: Pawel Lampe <[email protected]>
Date:   Mon Jun 19 23:41:24 2023 +0200

    Add `agent` and `map` tests for 'NavigationServer3D'

    This commits fixes a bug in `free()` function as well.

commit 4067907074f4d2141f03f5dec82bfa71bf7a51bc
Author: Samuele Panzeri <[email protected]>
Date:   Mon Apr 24 12:46:07 2023 +0200

    Fix insert key crash with no animation

commit d7af287ce3108f74799a7d0efd59b454253f6f68
Merge: 248e5245e4 f1e79e2581
Author: Yuri Sizov <[email protected]>
Date:   Tue Jun 20 17:39:08 2023 +0200

    Merge pull request #78478 from YuriSizov/gdscript-fix-container-element-cmp

    Make container element type comparison safe

commit f1e79e2581047f954cd7739f2c5f7c45775131ae
Author: Yuri Sizov <[email protected]>
Date:   Tue Jun 20 17:04:57 2023 +0200

    Make container element type comparison safe

commit 248e5245e41ed80069eca12fcb523092fe848f28
Merge: 904db6e8cb 2a12213c31
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 15:12:39 2023 +0200

    Merge pull request #73540 from mashumafi/fix-typed-array-add

    Fix: Typed arrays aren't working with +

commit 904db6e8cbc3902f8ff93149d54f7d6f5d97bcea
Merge: af08b17f97 94b1bc0d68
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 14:56:22 2023 +0200

    Merge pull request #78467 from groud/fix_tilemap_preview

    Fix TileMap draw preview when switching CanvasItem editor tool

commit af08b17f97459b74bcb7253fb14baee06793f057
Merge: 70182cf708 8f6166bd14
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 14:56:19 2023 +0200

    Merge pull request #78466 from raulsntos/dotnet/define-constants-without-whitespace

    C#: Remove whitespace from define constants

commit 70182cf708140be91965dafaa7660cb8d380e30b
Merge: 22631f2ce3 8c564cd974
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 14:56:16 2023 +0200

    Merge pull request #78462 from akien-mga/ci-scu-linux-san

    CI: Use SCU build for Linux w/ sanitizers build

commit 22631f2ce31a4239dee2538ddb155c15536eebf6
Merge: 7dc69ff230 90446fe9f3
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 14:56:13 2023 +0200

    Merge pull request #78435 from akien-mga/scons-platform-icons

    SCons: Move platform logo/run icon to `export` folder

commit 7dc69ff2302fb1d1f47c3d0307915af063977b6b
Merge: dbe8712d4e e344bab8af
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 14:56:07 2023 +0200

    Merge pull request #74759 from AThousandShips/rid_overflow

    Handle RID validator overflow

commit 8f6166bd1451e2fd877f7ee921f874fab48f5a56
Author: Raul Santos <[email protected]>
Date:   Tue Jun 20 12:03:37 2023 +0200

    C#: Remove whitespace from define constants

    Co-authored-by: RedworkDE <[email protected]>

commit e344bab8af93649b0e00fade9362b704b7205251
Author: Ninni Pipping <[email protected]>
Date:   Fri Mar 10 17:25:28 2023 +0100

    Handle RID validator overflow

commit 90446fe9f381eaaa86caed2facc09ee1cf5fb52b
Author: Rémi Verschelde <[email protected]>
Date:   Mon Jun 19 11:28:22 2023 +0200

    SCons: Move platform logo/run icon to `export` folder

    Follow-up to #75932.
    Since these icons are only used by the export plugin, it makes sense to
    move them and generate the headers there.

    The whole `detect.is_active()` logic seems to be a leftover from before
    times, as far back as 1.0-stable it already wasn't used for anything.

    So I'm removing it and moving the export icon generation to
    `platform_methods`, where it makes more sense.

commit 8c564cd97406533e8e9a65e168979448930f94cb
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 10:09:01 2023 +0200

    CI: Use SCU build for Linux w/ sanitizers build

    It's the slowest build so a speedup from SCU is welcome.
    The other purpose of this change is to actually catch global scope
    conflicts which would break the SCU build.

    SCU builds have drawbacks as they won't fully validate that the
    includes are correct, but we should have enough other builds in the CI
    build matrix to catch this type of bug.

commit dbe8712d4eda555829283624df7c79faa4bc02ea
Merge: ddaefb3cd6 edff9ebd18
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 13:14:26 2023 +0200

    Merge pull request #78463 from AThousandShips/string_slice_doc

    Clarify `String.get_slice` behavior

commit ddaefb3cd680d19db6bacd03ffc38ac7a9ef0ec8
Merge: 798663294f a981158d1a
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 13:14:23 2023 +0200

    Merge pull request #78455 from aaronfranke/macos-fix-tex-format-valid

    macOS: Finish checking templates before validating texture formats

commit 798663294fca62619132f40d8f662be2bad41a33
Merge: 159f1ec301 bd65ae633d
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 13:14:20 2023 +0200

    Merge pull request #78452 from raulsntos/dotnet/compat-methods

    C#: Add compat overloads

commit 159f1ec3013065603a0998c94c75908fa91dcde9
Merge: 65628f23c5 8cdab04d7f
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 13:14:10 2023 +0200

    Merge pull request #78398 from Sauermann/fix-immediate-focus-out

    Fix that the focus-out notification got sent deferred

commit 65628f23c51d5a0e19582683a8ad766a70dee71a
Merge: b16ae85ce8 ce7f648694
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 13:14:07 2023 +0200

    Merge pull request #78175 from phil-hudson/fix-#78105

    Android: Set pending intent flag to stop insta-crash

commit b16ae85ce8a94cc51d9d23289c2f92f034c2c87f
Merge: 73ac33342f a0577eb23b
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 13:14:03 2023 +0200

    Merge pull request #78465 from dalexeev/gds-fix-get-script-name-collision

    GDScript: Fix `_get_script_name()` function collision for SCU build

commit 94b1bc0d6828aac50a78510df615d79d65a82fb4
Author: Gilles Roudière <[email protected]>
Date:   Tue Jun 20 12:12:01 2023 +0200

    Fix TileMap draw preview when switching CI editor tool

commit bd65ae633d527c7362ae8c7211d6bde627a2a841
Author: Raul Santos <[email protected]>
Date:   Thu Jun 8 21:18:49 2023 +0200

    C#: Add compat overloads

commit a0577eb23b303b2f60a9237c877bd2ca370a6cc2
Author: Danil Alexeev <[email protected]>
Date:   Tue Jun 20 12:03:54 2023 +0300

    GDScript: Fix `_get_script_name()` function collision for SCU build

commit ce7f648694300a34747c5bab665f7d7f5e51ff61
Author: Phil Hudson <[email protected]>
Date:   Tue Jun 13 18:52:57 2023 +0800

    fix(android): set pending intent flag to stop insta-crash

    fix(android): add conditional check for minimum sdk version

    fix(android): formatting

    fix(android): formatting

    fix(android): formatting

    fix(android): formatting again

commit edff9ebd1803a386aa3f5764a6cd338f027f375e
Author: Ninni Pipping <[email protected]>
Date:   Tue Jun 20 10:30:02 2023 +0200

    Clarify `String.get_slice` behavior

    Clarify that the function returns the whole string if there is no
    instances of the delimiter in the string.

commit 73ac33342fa8326e533604f43494844483dcca3d
Merge: dca1e0bef7 f3a6e04f8b
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 09:22:03 2023 +0200

    Merge pull request #78442 from smix8/navmesh_bake_geo_errors_4.x

    Fix potential crashes in navmesh bake geometry functions

commit dca1e0bef71ba33f895fff92acf0d331807a6433
Merge: 94a4da9de6 66272ea26e
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 09:21:39 2023 +0200

    Merge pull request #78436 from BastiaanOlij/fix_stereo_fog

    Fix volumetric fog in stereo by projection vertex in combined space

commit 94a4da9de60170e8b634fb7cc793cd4be43b9496
Merge: 0653f7a5b0 4492f7ff97
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 09:21:15 2023 +0200

    Merge pull request #78236 from AThousandShips/nine_tex_fix

    Make `NinePatchRect` listen to texture changes

commit 0653f7a5b05861288d6ffe519de2a2cf5ee21d8e
Merge: ca3283b22b 42bc437615
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 09:20:52 2023 +0200

    Merge pull request #77722 from ApplecrispEric/drag-drop-autocomplete

    Cancel autocomplete after initiating drag

commit ca3283b22b80a7f6a53ec05c5042d751cacff407
Merge: 2861253884 16f6f40669
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 09:20:27 2023 +0200

    Merge pull request #77278 from davthedev/stylebox-flat-polys-optimize

    Remove useless polygons from StyleBoxFlat drawing

commit 28612538847c812c4622ee4afb4e7aa2a58d032d
Merge: 49dedd6ce4 d19c376d2e
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 09:20:00 2023 +0200

    Merge pull request #74985 from Rubonnek/fix-audio-effect-leak-master

    Fix AudioEffectRecord circular reference

commit 49dedd6ce48b14bff89f0683a19e5904af930701
Merge: 217a20a8a0 4aecba68e3
Author: Rémi Verschelde <[email protected]>
Date:   Tue Jun 20 09:19:33 2023 +0200

    Merge pull request #74567 from Garym3/3-to-4-converter-brace-aggregate-fix

    Fix braces handling when parsing method arguments on project conversion

commit 4492f7ff970e766dccf85e4a59c9a984ebfb759b
Author: Ninni Pipping <[email protected]>
Date:   Wed Jun 14 10:33:04 2023 +0200

    Make `NinePatchRect` listen to texture changes

commit 4aecba68e347a31943dd864a5cb4b8628f351665
Author: Garym3 <[email protected]>
Date:   Mon Jun 19 22:46:42 2023 +…
@Rubonnek Rubonnek mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@ellenhp ellenhp Awaiting requested review from ellenhp

Assignees
No one assigned
Labels
bug topic:audio
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

AudioEffectRecord leaks memory when opening and closing editor with project (11 MB)
3 participants
@Rubonnek @akien-mga @ellenhp